From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966663AbcHBN1A (ORCPT ); Tue, 2 Aug 2016 09:27:00 -0400 Received: from smtprelay0048.hostedemail.com ([216.40.44.48]:43520 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935166AbcHBN0Y (ORCPT ); Tue, 2 Aug 2016 09:26:24 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2901:3138:3139:3140:3141:3142:3165:3353:3622:3865:3866:3868:3871:3874:4250:4321:5007:6261:6742:7875:9038:9040:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12296:12438:12517:12519:12555:12740:13439:14181:14659:14721:21080:21324:30012:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: boot85_37752043d0d37 X-Filterd-Recvd-Size: 3512 Date: Tue, 2 Aug 2016 09:26:20 -0400 From: Steven Rostedt To: Baole Ni Cc: tj@kernel.org, jiangshanlai@gmail.com, mathieu.desnoyers@efficios.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, mhocko@suse.com, tglx@linutronix.de, vkuznets@redhat.com, pmladek@suse.com, jpoimboe@redhat.com Subject: Re: [PATCH 1078/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160802092620.001cce94@gandalf.local.home> In-Reply-To: <20160802121426.21987-1-baolex.ni@intel.com> References: <20160802121426.21987-1-baolex.ni@intel.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Aug 2016 20:14:26 +0800 Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > NACK! I find 0444 more readable than S_IRUSR | S_IRGRP | S_IROTH. -- Steve > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni > --- > kernel/workqueue.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/kernel/workqueue.c b/kernel/workqueue.c > index e1c0e99..74d92b0 100644 > --- a/kernel/workqueue.c > +++ b/kernel/workqueue.c > @@ -284,11 +284,11 @@ static cpumask_var_t *wq_numa_possible_cpumask; > /* possible CPUs of each node */ > > static bool wq_disable_numa; > -module_param_named(disable_numa, wq_disable_numa, bool, 0444); > +module_param_named(disable_numa, wq_disable_numa, bool, S_IRUSR | S_IRGRP | S_IROTH); > > /* see the comment above the definition of WQ_POWER_EFFICIENT */ > static bool wq_power_efficient = IS_ENABLED(CONFIG_WQ_POWER_EFFICIENT_DEFAULT); > -module_param_named(power_efficient, wq_power_efficient, bool, 0444); > +module_param_named(power_efficient, wq_power_efficient, bool, S_IRUSR | S_IRGRP | S_IROTH); > > static bool wq_numa_enabled; /* unbound NUMA affinity enabled */ > > @@ -317,7 +317,7 @@ static bool wq_debug_force_rr_cpu = true; > #else > static bool wq_debug_force_rr_cpu = false; > #endif > -module_param_named(debug_force_rr_cpu, wq_debug_force_rr_cpu, bool, 0644); > +module_param_named(debug_force_rr_cpu, wq_debug_force_rr_cpu, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > > /* the per-cpu worker pools */ > static DEFINE_PER_CPU_SHARED_ALIGNED(struct worker_pool [NR_STD_WORKER_POOLS], cpu_worker_pools); > @@ -5423,7 +5423,7 @@ static const struct kernel_param_ops wq_watchdog_thresh_ops = { > }; > > module_param_cb(watchdog_thresh, &wq_watchdog_thresh_ops, &wq_watchdog_thresh, > - 0644); > + S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > > static void wq_watchdog_init(void) > {