From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966808AbcHBNsg (ORCPT ); Tue, 2 Aug 2016 09:48:36 -0400 Received: from smtprelay0046.hostedemail.com ([216.40.44.46]:33858 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966048AbcHBNrY (ORCPT ); Tue, 2 Aug 2016 09:47:24 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2901:3138:3139:3140:3141:3142:3352:3622:3865:3866:3868:3870:3871:3874:5007:6261:6742:7875:7903:9040:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12517:12519:12555:12740:13069:13311:13357:13439:14096:14097:14181:14659:14721:21080:21324:30012:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: yard44_41d78dfb33959 X-Filterd-Recvd-Size: 2688 Date: Tue, 2 Aug 2016 09:27:31 -0400 From: Steven Rostedt To: Baole Ni Cc: davem@davemloft.net, jiangshanlai@gmail.com, mathieu.desnoyers@efficios.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, oleg@redhat.com, gang.chen.5i5j@gmail.com, mhocko@suse.com, koct9i@gmail.com, aarcange@redhat.com, aryabinin@virtuozzo.com Subject: Re: [PATCH 1084/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160802092731.3e5c65e1@gandalf.local.home> In-Reply-To: <20160802121502.22394-1-baolex.ni@intel.com> References: <20160802121502.22394-1-baolex.ni@intel.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Aug 2016 20:15:02 +0800 Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > NACK! I find 0444 more readable than S_IRUSR | S_IRGRP | S_IROTH. -- Steve > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni > --- > net/802/mrp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/802/mrp.c b/net/802/mrp.c > index 72db278..4ff215f 100644 > --- a/net/802/mrp.c > +++ b/net/802/mrp.c > @@ -22,11 +22,11 @@ > #include > > static unsigned int mrp_join_time __read_mostly = 200; > -module_param(mrp_join_time, uint, 0644); > +module_param(mrp_join_time, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(mrp_join_time, "Join time in ms (default 200ms)"); > > static unsigned int mrp_periodic_time __read_mostly = 1000; > -module_param(mrp_periodic_time, uint, 0644); > +module_param(mrp_periodic_time, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(mrp_periodic_time, "Periodic time in ms (default 1s)"); > > MODULE_LICENSE("GPL");