From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754279AbcHBLMq (ORCPT ); Tue, 2 Aug 2016 07:12:46 -0400 Received: from mga01.intel.com ([192.55.52.88]:7894 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753967AbcHBLL5 (ORCPT ); Tue, 2 Aug 2016 07:11:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="1033562089" From: Baole Ni To: tony.luck@intel.com, fenghua.yu@intel.com, robert.jarzmik@free.fr, linux@armlinux.org.uk Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0013/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:34:16 +0800 Message-Id: <20160802103416.14622-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- arch/ia64/sn/kernel/tiocx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/ia64/sn/kernel/tiocx.c b/arch/ia64/sn/kernel/tiocx.c index e35f648..d4f99f9 100644 --- a/arch/ia64/sn/kernel/tiocx.c +++ b/arch/ia64/sn/kernel/tiocx.c @@ -484,7 +484,7 @@ static ssize_t store_cxdev_control(struct device *dev, struct device_attribute * return count; } -DEVICE_ATTR(cxdev_control, 0644, show_cxdev_control, store_cxdev_control); +DEVICE_ATTR(cxdev_control, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, show_cxdev_control, store_cxdev_control); static int __init tiocx_init(void) { -- 2.9.2