From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754418AbcHBLNH (ORCPT ); Tue, 2 Aug 2016 07:13:07 -0400 Received: from mga02.intel.com ([134.134.136.20]:27526 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754003AbcHBLMf (ORCPT ); Tue, 2 Aug 2016 07:12:35 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="1033562303" From: Baole Ni To: schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0021/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:34:54 +0800 Message-Id: <20160802103454.15161-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- arch/s390/kernel/idle.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/s390/kernel/idle.c b/arch/s390/kernel/idle.c index 7a55c29..db60941 100644 --- a/arch/s390/kernel/idle.c +++ b/arch/s390/kernel/idle.c @@ -63,7 +63,7 @@ static ssize_t show_idle_count(struct device *dev, } while (read_seqcount_retry(&idle->seqcount, seq)); return sprintf(buf, "%llu\n", idle_count); } -DEVICE_ATTR(idle_count, 0444, show_idle_count, NULL); +DEVICE_ATTR(idle_count, S_IRUSR | S_IRGRP | S_IROTH, show_idle_count, NULL); static ssize_t show_idle_time(struct device *dev, struct device_attribute *attr, char *buf) @@ -82,7 +82,7 @@ static ssize_t show_idle_time(struct device *dev, idle_time += idle_enter ? ((idle_exit ? : now) - idle_enter) : 0; return sprintf(buf, "%llu\n", idle_time >> 12); } -DEVICE_ATTR(idle_time_us, 0444, show_idle_time, NULL); +DEVICE_ATTR(idle_time_us, S_IRUSR | S_IRGRP | S_IROTH, show_idle_time, NULL); cputime64_t arch_cpu_idle_time(int cpu) { -- 2.9.2