From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752335AbcHBLNm (ORCPT ); Tue, 2 Aug 2016 07:13:42 -0400 Received: from mga04.intel.com ([192.55.52.120]:32824 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754437AbcHBLNM (ORCPT ); Tue, 2 Aug 2016 07:13:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="1033562499" From: Baole Ni To: davem@davemloft.net, dalias@libc.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, adam.buchbinder@gmail.com, julian.calaby@gmail.com, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0028/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:35:31 +0800 Message-Id: <20160802103531.15637-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- arch/sparc/kernel/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sparc/kernel/sysfs.c b/arch/sparc/kernel/sysfs.c index fa8e21a..881ba0b 100644 --- a/arch/sparc/kernel/sysfs.c +++ b/arch/sparc/kernel/sysfs.c @@ -163,7 +163,7 @@ static ssize_t store_mmustat_enable(struct device *s, return count; } -static DEVICE_ATTR(mmustat_enable, 0644, show_mmustat_enable, store_mmustat_enable); +static DEVICE_ATTR(mmustat_enable, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, show_mmustat_enable, store_mmustat_enable); static int mmu_stats_supported; -- 2.9.2