From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932104AbcHBL1q (ORCPT ); Tue, 2 Aug 2016 07:27:46 -0400 Received: from mga14.intel.com ([192.55.52.115]:21717 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754780AbcHBLTR (ORCPT ); Tue, 2 Aug 2016 07:19:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="1028245168" From: Baole Ni To: 3chas3@gmail.com, tj@kernel.org, lenb@kernel.org, x86@kernel.org, hpa@zytor.com Cc: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0069/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:38:23 +0800 Message-Id: <20160802103823.18354-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/atm/firestream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c index 85aaf22..dfd3da9 100644 --- a/drivers/atm/firestream.c +++ b/drivers/atm/firestream.c @@ -312,7 +312,7 @@ static int fs_debug = 0; #ifdef MODULE #ifdef DEBUG -module_param(fs_debug, int, 0644); +module_param(fs_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); #endif module_param(loopback, int, 0); module_param(num, int, 0); -- 2.9.2