From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757280AbcHBS1q (ORCPT ); Tue, 2 Aug 2016 14:27:46 -0400 Received: from mga02.intel.com ([134.134.136.20]:4388 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754181AbcHBLRr (ORCPT ); Tue, 2 Aug 2016 07:17:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="858083181" From: Baole Ni To: tim@cyberelk.net, lars.ellenberg@linbit.com, pavel@ucw.cz, gregkh@linuxfoundation.org, hpa@zytor.com, x86@kernel.org Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0085/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:39:27 +0800 Message-Id: <20160802103927.19425-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/block/paride/bpck6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/paride/bpck6.c b/drivers/block/paride/bpck6.c index ec64e7f..9547917 100644 --- a/drivers/block/paride/bpck6.c +++ b/drivers/block/paride/bpck6.c @@ -262,6 +262,6 @@ static void __exit bpck6_exit(void) MODULE_LICENSE("GPL"); MODULE_AUTHOR("Micro Solutions Inc."); MODULE_DESCRIPTION("BACKPACK Protocol module, compatible with PARIDE"); -module_param(verbose, bool, 0644); +module_param(verbose, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); module_init(bpck6_init) module_exit(bpck6_exit) -- 2.9.2