From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752777AbcHBS2n (ORCPT ); Tue, 2 Aug 2016 14:28:43 -0400 Received: from mga11.intel.com ([192.55.52.93]:2346 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754482AbcHBLRr (ORCPT ); Tue, 2 Aug 2016 07:17:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="1006926355" From: Baole Ni To: josh.h.morris@us.ibm.com, pjk1939@linux.vnet.ibm.com, pavel@ucw.cz, gregkh@linuxfoundation.org, hpa@zytor.com, x86@kernel.org Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0090/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:39:47 +0800 Message-Id: <20160802103947.19755-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/block/rsxx/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c index 34997df..b2b8e40 100644 --- a/drivers/block/rsxx/core.c +++ b/drivers/block/rsxx/core.c @@ -49,11 +49,11 @@ MODULE_LICENSE("GPL"); MODULE_VERSION(DRIVER_VERSION); static unsigned int force_legacy = NO_LEGACY; -module_param(force_legacy, uint, 0444); +module_param(force_legacy, uint, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(force_legacy, "Force the use of legacy type PCI interrupts"); static unsigned int sync_start = 1; -module_param(sync_start, uint, 0444); +module_param(sync_start, uint, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(sync_start, "On by Default: Driver load will not complete " "until the card startup has completed."); -- 2.9.2