From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757314AbcHBSby (ORCPT ); Tue, 2 Aug 2016 14:31:54 -0400 Received: from mga04.intel.com ([192.55.52.120]:22169 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754471AbcHBLRr (ORCPT ); Tue, 2 Aug 2016 07:17:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="1028245804" From: Baole Ni To: josh.h.morris@us.ibm.com, pjk1939@linux.vnet.ibm.com, pavel@ucw.cz, gregkh@linuxfoundation.org, hpa@zytor.com, x86@kernel.org Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0091/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:39:52 +0800 Message-Id: <20160802103952.19821-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/block/rsxx/dev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/rsxx/dev.c b/drivers/block/rsxx/dev.c index e1b8b70..fc11649 100644 --- a/drivers/block/rsxx/dev.c +++ b/drivers/block/rsxx/dev.c @@ -38,7 +38,7 @@ #include "rsxx_priv.h" static unsigned int blkdev_minors = 64; -module_param(blkdev_minors, uint, 0444); +module_param(blkdev_minors, uint, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(blkdev_minors, "Number of minors(partitions)"); /* @@ -47,11 +47,11 @@ MODULE_PARM_DESC(blkdev_minors, "Number of minors(partitions)"); * value. */ static unsigned int blkdev_max_hw_sectors = 1024; -module_param(blkdev_max_hw_sectors, uint, 0444); +module_param(blkdev_max_hw_sectors, uint, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(blkdev_max_hw_sectors, "Max hw sectors for a single BIO"); static unsigned int enable_blkdev = 1; -module_param(enable_blkdev , uint, 0444); +module_param(enable_blkdev , uint, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(enable_blkdev, "Enable block device interfaces"); -- 2.9.2