From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965728AbcHBNKH (ORCPT ); Tue, 2 Aug 2016 09:10:07 -0400 Received: from mga03.intel.com ([134.134.136.65]:55677 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966091AbcHBNJF (ORCPT ); Tue, 2 Aug 2016 09:09:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="858083615" From: Baole Ni To: josh.h.morris@us.ibm.com, pjk1939@linux.vnet.ibm.com, pavel@ucw.cz, gregkh@linuxfoundation.org, hpa@zytor.com, x86@kernel.org Cc: linux-kernel@vger.kernel.org, axboe@fb.com, shraddha.6596@gmail.com, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0093/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:40:03 +0800 Message-Id: <20160802104003.19957-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/block/sx8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/sx8.c b/drivers/block/sx8.c index ba4bfe9..e2b6c08 100644 --- a/drivers/block/sx8.c +++ b/drivers/block/sx8.c @@ -66,7 +66,7 @@ MODULE_VERSION(DRV_VERSION); * but problems seem to occur when you exceed ~30, even on newer hardware. */ static int max_queue = 1; -module_param(max_queue, int, 0444); +module_param(max_queue, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(max_queue, "Maximum number of queued commands. (min==1, max==30, safe==1)"); -- 2.9.2