From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755488AbcHBL2b (ORCPT ); Tue, 2 Aug 2016 07:28:31 -0400 Received: from mga03.intel.com ([134.134.136.65]:63608 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754571AbcHBLTR (ORCPT ); Tue, 2 Aug 2016 07:19:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="1028245902" From: Baole Ni To: josh.h.morris@us.ibm.com, pjk1939@linux.vnet.ibm.com, pavel@ucw.cz, gregkh@linuxfoundation.org, hpa@zytor.com, x86@kernel.org Cc: linux-kernel@vger.kernel.org, axboe@fb.com, snitzer@redhat.com, ming.l@ssi.samsung.com, martin.petersen@oracle.com, kent.overstreet@gmail.com, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0094/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:40:12 +0800 Message-Id: <20160802104012.20025-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/block/umem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/umem.c b/drivers/block/umem.c index 7939b9f..244cfb2 100644 --- a/drivers/block/umem.c +++ b/drivers/block/umem.c @@ -79,7 +79,7 @@ static int debug; #define DEBUG_LED_ON_TRANSFER 0x01 #define DEBUG_BATTERY_POLLING 0x02 -module_param(debug, int, 0644); +module_param(debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(debug, "Debug bitmask"); static int pci_read_cmd = 0x0C; /* Read Multiple */ -- 2.9.2