From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754880AbcHBLY2 (ORCPT ); Tue, 2 Aug 2016 07:24:28 -0400 Received: from mga01.intel.com ([192.55.52.88]:24276 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755007AbcHBLXO (ORCPT ); Tue, 2 Aug 2016 07:23:14 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="1033564757" From: Baole Ni To: marcel@holtmann.org, gustavo@padovan.org, johan.hedberg@gmail.com, gregkh@linuxfoundation.org, hpa@zytor.com, x86@kernel.org Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, martin.petersen@oracle.com, kent.overstreet@gmail.com Subject: [PATCH 0097/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:40:25 +0800 Message-Id: <20160802104025.20223-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/bluetooth/btusb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index a3be65e..ac96e89 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -3174,13 +3174,13 @@ static struct usb_driver btusb_driver = { module_usb_driver(btusb_driver); -module_param(disable_scofix, bool, 0644); +module_param(disable_scofix, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(disable_scofix, "Disable fixup of wrong SCO buffer size"); -module_param(force_scofix, bool, 0644); +module_param(force_scofix, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(force_scofix, "Force fixup of wrong SCO buffers size"); -module_param(reset, bool, 0644); +module_param(reset, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(reset, "Send HCI reset command on initialization"); MODULE_AUTHOR("Marcel Holtmann "); -- 2.9.2