From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755418AbcHBL2S (ORCPT ); Tue, 2 Aug 2016 07:28:18 -0400 Received: from mga01.intel.com ([192.55.52.88]:38220 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754769AbcHBLTR (ORCPT ); Tue, 2 Aug 2016 07:19:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="1018186815" From: Baole Ni To: arnd@arndb.de, gregkh@linuxfoundation.org, johan.hedberg@gmail.com, hpa@zytor.com, x86@kernel.org Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, jslaby@suse.cz, peter@korsgaard.com, lee.jones@linaro.org Subject: [PATCH 0107/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:41:12 +0800 Message-Id: <20160802104112.20885-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/char/mbcs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/mbcs.c b/drivers/char/mbcs.c index 67d4264..88e7b00 100644 --- a/drivers/char/mbcs.c +++ b/drivers/char/mbcs.c @@ -719,7 +719,7 @@ static ssize_t store_algo(struct device *dev, struct device_attribute *attr, con return count; } -DEVICE_ATTR(algo, 0644, show_algo, store_algo); +DEVICE_ATTR(algo, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, show_algo, store_algo); /** * mbcs_probe - Initialize for device -- 2.9.2