From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964942AbcHBM2K (ORCPT ); Tue, 2 Aug 2016 08:28:10 -0400 Received: from mga03.intel.com ([134.134.136.65]:21397 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934832AbcHBM1W (ORCPT ); Tue, 2 Aug 2016 08:27:22 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="743066273" From: Baole Ni To: dan.j.williams@intel.com, vinod.koul@intel.com, davem@davemloft.net, hpa@zytor.com, x86@kernel.org Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, okaya@codeaurora.org, andy.shevchenko@gmail.com, chuansheng.liu@intel.com, baolex.ni@intel.com, lee.jones@linaro.org Subject: [PATCH 0136/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:43:38 +0800 Message-Id: <20160802104338.22816-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/dma/qcom/hidma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c index 41b5c6d..7138e62 100644 --- a/drivers/dma/qcom/hidma.c +++ b/drivers/dma/qcom/hidma.c @@ -99,7 +99,7 @@ static void hidma_free(struct hidma_dev *dmadev) } static unsigned int nr_desc_prm; -module_param(nr_desc_prm, uint, 0644); +module_param(nr_desc_prm, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(nr_desc_prm, "number of descriptors (default: 0)"); -- 2.9.2