From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935704AbcHBRFX (ORCPT ); Tue, 2 Aug 2016 13:05:23 -0400 Received: from mga04.intel.com ([192.55.52.120]:20491 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932849AbcHBMAA (ORCPT ); Tue, 2 Aug 2016 08:00:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="149290655" From: Baole Ni To: matt@codeblueprint.co.uk, ccross@android.com, keescook@chromium.org, tony.luck@intel.com, m.chehab@samsung.com, lho@apm.com, dougthompson@xmission.com, bp@alien8.de Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, lee.jones@linaro.org Subject: [PATCH 0171/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:46:25 +0800 Message-Id: <20160802104625.25138-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/firmware/efi/efivars.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/firmware/efi/efivars.c b/drivers/firmware/efi/efivars.c index 116b244..0510433 100644 --- a/drivers/firmware/efi/efivars.c +++ b/drivers/firmware/efi/efivars.c @@ -390,11 +390,11 @@ static void efivar_release(struct kobject *kobj) kfree(var); } -static EFIVAR_ATTR(guid, 0400, efivar_guid_read, NULL); -static EFIVAR_ATTR(attributes, 0400, efivar_attr_read, NULL); -static EFIVAR_ATTR(size, 0400, efivar_size_read, NULL); -static EFIVAR_ATTR(data, 0400, efivar_data_read, NULL); -static EFIVAR_ATTR(raw_var, 0600, efivar_show_raw, efivar_store_raw); +static EFIVAR_ATTR(guid, S_IRUSR, efivar_guid_read, NULL); +static EFIVAR_ATTR(attributes, S_IRUSR, efivar_attr_read, NULL); +static EFIVAR_ATTR(size, S_IRUSR, efivar_size_read, NULL); +static EFIVAR_ATTR(data, S_IRUSR, efivar_data_read, NULL); +static EFIVAR_ATTR(raw_var, S_IRUSR | S_IWUSR, efivar_show_raw, efivar_store_raw); static struct attribute *def_attrs[] = { &efivar_attr_guid.attr, -- 2.9.2