From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936140AbcHBSOr (ORCPT ); Tue, 2 Aug 2016 14:14:47 -0400 Received: from mga11.intel.com ([192.55.52.93]:14032 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755525AbcHBL3K (ORCPT ); Tue, 2 Aug 2016 07:29:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="1006929053" From: Baole Ni To: matt@codeblueprint.co.uk, ccross@android.com, keescook@chromium.org, tony.luck@intel.com, m.chehab@samsung.com, lho@apm.com, dougthompson@xmission.com, bp@alien8.de Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, lee.jones@linaro.org Subject: [PATCH 0172/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:46:31 +0800 Message-Id: <20160802104631.25206-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/firmware/google/gsmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c index f1ab05e..ea451d5 100644 --- a/drivers/firmware/google/gsmi.c +++ b/drivers/firmware/google/gsmi.c @@ -129,7 +129,7 @@ struct gsmi_log_entry_type_1 { */ #define GSMI_DEFAULT_SPINCOUNT 0x10000 static unsigned int spincount = GSMI_DEFAULT_SPINCOUNT; -module_param(spincount, uint, 0600); +module_param(spincount, uint, S_IRUSR | S_IWUSR); MODULE_PARM_DESC(spincount, "The number of loop iterations to use when using the spin handshake."); -- 2.9.2