From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755600AbcHBLeH (ORCPT ); Tue, 2 Aug 2016 07:34:07 -0400 Received: from mga02.intel.com ([134.134.136.20]:54498 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755881AbcHBLdK (ORCPT ); Tue, 2 Aug 2016 07:33:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="1028248711" From: Baole Ni To: rubini@gnudd.com, ccross@android.com, keescook@chromium.org, tony.luck@intel.com, matt@codeblueprint.co.uk, m.chehab@samsung.com, lho@apm.com, dougthompson@xmission.com, bp@alien8.de Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, lee.jones@linaro.org Subject: [PATCH 0173/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:46:36 +0800 Message-Id: <20160802104636.25272-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/fmc/fmc-dump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/fmc/fmc-dump.c b/drivers/fmc/fmc-dump.c index c91afd6..224cd60 100644 --- a/drivers/fmc/fmc-dump.c +++ b/drivers/fmc/fmc-dump.c @@ -14,9 +14,9 @@ #include static int fmc_must_dump_eeprom; -module_param_named(dump_eeprom, fmc_must_dump_eeprom, int, 0644); +module_param_named(dump_eeprom, fmc_must_dump_eeprom, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); static int fmc_must_dump_sdb; -module_param_named(dump_sdb, fmc_must_dump_sdb, int, 0644); +module_param_named(dump_sdb, fmc_must_dump_sdb, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); #define LINELEN 16 -- 2.9.2