From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933418AbcHBMAv (ORCPT ); Tue, 2 Aug 2016 08:00:51 -0400 Received: from mga02.intel.com ([134.134.136.20]:59422 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933080AbcHBMAM (ORCPT ); Tue, 2 Aug 2016 08:00:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="1018189312" From: Baole Ni To: rubini@gnudd.com, ccross@android.com, keescook@chromium.org, tony.luck@intel.com, matt@codeblueprint.co.uk, m.chehab@samsung.com, lho@apm.com, dougthompson@xmission.com, bp@alien8.de Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, lee.jones@linaro.org Subject: [PATCH 0174/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:46:40 +0800 Message-Id: <20160802104640.25338-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/fmc/fmc-fakedev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/fmc/fmc-fakedev.c b/drivers/fmc/fmc-fakedev.c index 941d093..2ace110 100644 --- a/drivers/fmc/fmc-fakedev.c +++ b/drivers/fmc/fmc-fakedev.c @@ -26,11 +26,11 @@ /* The user can pass up to 4 names of eeprom images to load */ static char *ff_eeprom[FF_MAX_MEZZANINES]; static int ff_nr_eeprom; -module_param_array_named(eeprom, ff_eeprom, charp, &ff_nr_eeprom, 0444); +module_param_array_named(eeprom, ff_eeprom, charp, &ff_nr_eeprom, S_IRUSR | S_IRGRP | S_IROTH); /* The user can ask for a multi-mezzanine carrier, with the default eeprom */ static int ff_nr_dev = 1; -module_param_named(ndev, ff_nr_dev, int, 0444); +module_param_named(ndev, ff_nr_dev, int, S_IRUSR | S_IRGRP | S_IROTH); /* Lazily, don't support the "standard" module parameters */ -- 2.9.2