From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932966AbcHBLx5 (ORCPT ); Tue, 2 Aug 2016 07:53:57 -0400 Received: from mga03.intel.com ([134.134.136.65]:35341 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932877AbcHBLxT (ORCPT ); Tue, 2 Aug 2016 07:53:19 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="858088253" From: Baole Ni To: linus.walleij@linaro.org, gnurou@gmail.com, tony.luck@intel.com, matt@codeblueprint.co.uk, m.chehab@samsung.com, lho@apm.com, dougthompson@xmission.com, bp@alien8.de Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, lee.jones@linaro.org Subject: [PATCH 0177/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:46:55 +0800 Message-Id: <20160802104655.25537-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/gpio/gpio-cs5535.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-cs5535.c b/drivers/gpio/gpio-cs5535.c index 90278b1..b17c3f9 100644 --- a/drivers/gpio/gpio-cs5535.c +++ b/drivers/gpio/gpio-cs5535.c @@ -39,7 +39,7 @@ #define GPIO_DEFAULT_MASK 0x0F7FFFFF static ulong mask = GPIO_DEFAULT_MASK; -module_param_named(mask, mask, ulong, 0444); +module_param_named(mask, mask, ulong, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(mask, "GPIO channel mask."); /* -- 2.9.2