From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755394AbcHBLgG (ORCPT ); Tue, 2 Aug 2016 07:36:06 -0400 Received: from mga14.intel.com ([192.55.52.115]:22321 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755732AbcHBLae (ORCPT ); Tue, 2 Aug 2016 07:30:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="743067625" From: Baole Ni To: p.zabel@pengutronix.de, airlied@linux.ie, kyungmin.park@samsung.com, kgene@kernel.org, k.kozlowski@samsung.com, dougthompson@xmission.com, bp@alien8.de Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, treding@nvidia.com, wuninsu@gmail.com Subject: [PATCH 0198/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:48:52 +0800 Message-Id: <20160802104852.26952-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/gpu/drm/imx/imx-drm-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c index 8265665..8159ff2 100644 --- a/drivers/gpu/drm/imx/imx-drm-core.c +++ b/drivers/gpu/drm/imx/imx-drm-core.c @@ -50,7 +50,7 @@ struct imx_drm_crtc { #if IS_ENABLED(CONFIG_DRM_FBDEV_EMULATION) static int legacyfb_depth = 16; -module_param(legacyfb_depth, int, 0444); +module_param(legacyfb_depth, int, S_IRUSR | S_IRGRP | S_IROTH); #endif unsigned int imx_drm_crtc_id(struct imx_drm_crtc *crtc) -- 2.9.2