From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936239AbcHBSQM (ORCPT ); Tue, 2 Aug 2016 14:16:12 -0400 Received: from mga04.intel.com ([192.55.52.120]:9297 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755053AbcHBL2a (ORCPT ); Tue, 2 Aug 2016 07:28:30 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="1033568747" From: Baole Ni To: jikos@kernel.org, benjamin.tissoires@redhat.com, thellstrom@vmware.com, airlied@linux.ie, kgene@kernel.org, k.kozlowski@samsung.com, dougthompson@xmission.com, bp@alien8.de Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, alexander.deucher@amd.com, ville.syrjala@linux.intel.com Subject: [PATCH 0217/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:50:34 +0800 Message-Id: <20160802105034.28221-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/hid/hid-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 8ea3a26..ad11fb2 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -46,12 +46,12 @@ #define DRIVER_LICENSE "GPL" int hid_debug = 0; -module_param_named(debug, hid_debug, int, 0600); +module_param_named(debug, hid_debug, int, S_IRUSR | S_IWUSR); MODULE_PARM_DESC(debug, "toggle HID debugging messages"); EXPORT_SYMBOL_GPL(hid_debug); static int hid_ignore_special_drivers = 0; -module_param_named(ignore_special_drivers, hid_ignore_special_drivers, int, 0600); +module_param_named(ignore_special_drivers, hid_ignore_special_drivers, int, S_IRUSR | S_IWUSR); MODULE_PARM_DESC(ignore_special_drivers, "Ignore any special drivers and handle all devices by generic driver"); /* -- 2.9.2