From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757055AbcHBSLV (ORCPT ); Tue, 2 Aug 2016 14:11:21 -0400 Received: from mga09.intel.com ([134.134.136.24]:43608 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751831AbcHBL3Y (ORCPT ); Tue, 2 Aug 2016 07:29:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1028250383" From: Baole Ni To: jikos@kernel.org, benjamin.tissoires@redhat.com, airlied@linux.ie, kgene@kernel.org, k.kozlowski@samsung.com, dougthompson@xmission.com, bp@alien8.de Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, dtor@chromium.org, bleung@chromium.org, mika.westerberg@linux.intel.com, aduggan@synaptics.com, dianders@chromium.org, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0231/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:51:42 +0800 Message-Id: <20160802105142.29147-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/hid/i2c-hid/i2c-hid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c index 2e021ba..316d995 100644 --- a/drivers/hid/i2c-hid/i2c-hid.c +++ b/drivers/hid/i2c-hid/i2c-hid.c @@ -51,7 +51,7 @@ /* debug option */ static bool debug; -module_param(debug, bool, 0444); +module_param(debug, bool, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(debug, "print a lot of debug information"); #define i2c_hid_dbg(ihid, fmt, arg...) \ -- 2.9.2