From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755888AbcHBLc2 (ORCPT ); Tue, 2 Aug 2016 07:32:28 -0400 Received: from mga04.intel.com ([192.55.52.120]:19688 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755595AbcHBLac (ORCPT ); Tue, 2 Aug 2016 07:30:32 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1006931859" From: Baole Ni To: alexander.shishkin@linux.intel.com, jdelvare@suse.com, linux@roeck-us.net, airlied@linux.ie, kgene@kernel.org, k.kozlowski@samsung.com, dougthompson@xmission.com, bp@alien8.de Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, aduggan@synaptics.com, dianders@chromium.org Subject: [PATCH 0243/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:52:40 +0800 Message-Id: <20160802105240.29942-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/hwtracing/stm/heartbeat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwtracing/stm/heartbeat.c b/drivers/hwtracing/stm/heartbeat.c index 3da7b67..92b3726 100644 --- a/drivers/hwtracing/stm/heartbeat.c +++ b/drivers/hwtracing/stm/heartbeat.c @@ -26,8 +26,8 @@ static int nr_devs = 4; static int interval_ms = 10; -module_param(nr_devs, int, 0400); -module_param(interval_ms, int, 0600); +module_param(nr_devs, int, S_IRUSR); +module_param(interval_ms, int, S_IRUSR | S_IWUSR); static struct stm_heartbeat { struct stm_source_data data; -- 2.9.2