From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755777AbcHBSES (ORCPT ); Tue, 2 Aug 2016 14:04:18 -0400 Received: from mga03.intel.com ([134.134.136.65]:28976 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755858AbcHBLgZ (ORCPT ); Tue, 2 Aug 2016 07:36:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="149293283" From: Baole Ni To: davem@davemloft.net, linux@roeck-us.net, airlied@linux.ie, kgene@kernel.org, k.kozlowski@samsung.com, dougthompson@xmission.com, bp@alien8.de Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, aduggan@synaptics.com, dianders@chromium.org Subject: [PATCH 0249/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:53:10 +0800 Message-Id: <20160802105310.30339-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/ide/ide-sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ide/ide-sysfs.c b/drivers/ide/ide-sysfs.c index 84a6a9e..a210338a 100644 --- a/drivers/ide/ide-sysfs.c +++ b/drivers/ide/ide-sysfs.c @@ -65,9 +65,9 @@ static ssize_t serial_show(struct device *dev, struct device_attribute *attr, ide_drive_t *drive = to_ide_device(dev); return sprintf(buf, "%s\n", (char *)&drive->id[ATA_ID_SERNO]); } -static DEVICE_ATTR(serial, 0400, serial_show, NULL); +static DEVICE_ATTR(serial, S_IRUSR, serial_show, NULL); -static DEVICE_ATTR(unload_heads, 0644, ide_park_show, ide_park_store); +static DEVICE_ATTR(unload_heads, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, ide_park_show, ide_park_store); static struct attribute *ide_attrs[] = { &dev_attr_media.attr, -- 2.9.2