mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Baole Ni <baolex.ni@intel.com>
To: swise@chelsio.com, dledford@redhat.com, sean.hefty@intel.com,
	hal.rosenstock@gmail.com, airlied@linux.ie, kgene@kernel.org,
	k.kozlowski@samsung.com, dougthompson@xmission.com, bp@alien8.de
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	chuansheng.liu@intel.com, baolex.ni@intel.com, hch@infradead.org,
	matanb@mellanox.com, markb@mellanox.com,
	jgunthorpe@obsidianresearch.com, dean.luick@intel.com
Subject: [PATCH 0258/1285] Replace numeric parameter like 0444 with macro
Date: Tue,  2 Aug 2016 18:54:02 +0800	[thread overview]
Message-ID: <20160802105402.30940-1-baolex.ni@intel.com> (raw)

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/infiniband/hw/cxgb4/qp.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c
index e8993e4..3b2d95d 100644
--- a/drivers/infiniband/hw/cxgb4/qp.c
+++ b/drivers/infiniband/hw/cxgb4/qp.c
@@ -35,27 +35,27 @@
 #include "iw_cxgb4.h"
 
 static int db_delay_usecs = 1;
-module_param(db_delay_usecs, int, 0644);
+module_param(db_delay_usecs, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(db_delay_usecs, "Usecs to delay awaiting db fifo to drain");
 
 static int ocqp_support = 1;
-module_param(ocqp_support, int, 0644);
+module_param(ocqp_support, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(ocqp_support, "Support on-chip SQs (default=1)");
 
 int db_fc_threshold = 1000;
-module_param(db_fc_threshold, int, 0644);
+module_param(db_fc_threshold, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(db_fc_threshold,
 		 "QP count/threshold that triggers"
 		 " automatic db flow control mode (default = 1000)");
 
 int db_coalescing_threshold;
-module_param(db_coalescing_threshold, int, 0644);
+module_param(db_coalescing_threshold, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(db_coalescing_threshold,
 		 "QP count/threshold that triggers"
 		 " disabling db coalescing (default = 0)");
 
 static int max_fr_immd = T4_MAX_FR_IMMD;
-module_param(max_fr_immd, int, 0644);
+module_param(max_fr_immd, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(max_fr_immd, "fastreg threshold for using DSGL instead of immedate");
 
 static int alloc_ird(struct c4iw_dev *dev, u32 ird)
-- 
2.9.2

             reply	other threads:[~2016-08-02 15:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02 10:54 Baole Ni [this message]
2016-08-02 14:13 ` Steve Wise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160802105402.30940-1-baolex.ni@intel.com \
    --to=baolex.ni@intel.com \
    --cc=airlied@linux.ie \
    --cc=bp@alien8.de \
    --cc=chuansheng.liu@intel.com \
    --cc=dean.luick@intel.com \
    --cc=dledford@redhat.com \
    --cc=dougthompson@xmission.com \
    --cc=hal.rosenstock@gmail.com \
    --cc=hch@infradead.org \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=markb@mellanox.com \
    --cc=matanb@mellanox.com \
    --cc=sean.hefty@intel.com \
    --cc=swise@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®