From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966249AbcHBOzl (ORCPT ); Tue, 2 Aug 2016 10:55:41 -0400 Received: from mga04.intel.com ([192.55.52.120]:43131 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935015AbcHBMik (ORCPT ); Tue, 2 Aug 2016 08:38:40 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1033570855" From: Baole Ni To: dmitry.torokhov@gmail.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, dledford@redhat.com, bp@alien8.de Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, alex.estrin@intel.com, nab@linux-iscsi.org, haggaie@mellanox.com Subject: [PATCH 0274/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:55:39 +0800 Message-Id: <20160802105539.32018-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/input/gameport/gameport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/gameport/gameport.c b/drivers/input/gameport/gameport.c index 4a2a9e3..c6767dd 100644 --- a/drivers/input/gameport/gameport.c +++ b/drivers/input/gameport/gameport.c @@ -32,7 +32,7 @@ MODULE_DESCRIPTION("Generic gameport layer"); MODULE_LICENSE("GPL"); static bool use_ktime = true; -module_param(use_ktime, bool, 0400); +module_param(use_ktime, bool, S_IRUSR); MODULE_PARM_DESC(use_ktime, "Use ktime for measuring I/O speed"); /* -- 2.9.2