From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968239AbcHBSD7 (ORCPT ); Tue, 2 Aug 2016 14:03:59 -0400 Received: from mga02.intel.com ([134.134.136.20]:54498 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755883AbcHBLgZ (ORCPT ); Tue, 2 Aug 2016 07:36:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1018194131" From: Baole Ni To: rpurdie@rpsys.net, j.anaszewski@samsung.com, hal.rosenstock@gmail.com, dledford@redhat.com, sean.hefty@intel.com, bp@alien8.de Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, jiri.prchal@aksignal.cz, ulf.hansson@linaro.org, linus.walleij@linaro.org, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0305/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:58:30 +0800 Message-Id: <20160802105830.1799-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/leds/trigger/ledtrig-heartbeat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/trigger/ledtrig-heartbeat.c b/drivers/leds/trigger/ledtrig-heartbeat.c index c9f3862..38b4fe0 100644 --- a/drivers/leds/trigger/ledtrig-heartbeat.c +++ b/drivers/leds/trigger/ledtrig-heartbeat.c @@ -112,7 +112,7 @@ static ssize_t led_invert_store(struct device *dev, return size; } -static DEVICE_ATTR(invert, 0644, led_invert_show, led_invert_store); +static DEVICE_ATTR(invert, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, led_invert_show, led_invert_store); static void heartbeat_trig_activate(struct led_classdev *led_cdev) { -- 2.9.2