From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935976AbcHBRiU (ORCPT ); Tue, 2 Aug 2016 13:38:20 -0400 Received: from mga11.intel.com ([192.55.52.93]:9850 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932294AbcHBLoI (ORCPT ); Tue, 2 Aug 2016 07:44:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="743072761" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, crope@iki.fi, hal.rosenstock@gmail.com, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, peter.griffin@linaro.org, mkrufky@linuxtv.org, chuansheng.liu@intel.com, baolex.ni@intel.com, standby24x7@gmail.com Subject: [PATCH 0384/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:06:27 +0800 Message-Id: <20160802110627.7373-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/dvb-frontends/stv0367.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/stv0367.c b/drivers/media/dvb-frontends/stv0367.c index abc379a..cfc4279 100644 --- a/drivers/media/dvb-frontends/stv0367.c +++ b/drivers/media/dvb-frontends/stv0367.c @@ -37,10 +37,10 @@ #define MAX_XFER_SIZE 64 static int stvdebug; -module_param_named(debug, stvdebug, int, 0644); +module_param_named(debug, stvdebug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); static int i2cdebug; -module_param_named(i2c_debug, i2cdebug, int, 0644); +module_param_named(i2c_debug, i2cdebug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); #define dprintk(args...) \ do { \ -- 2.9.2