From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935846AbcHBRYE (ORCPT ); Tue, 2 Aug 2016 13:24:04 -0400 Received: from mga11.intel.com ([192.55.52.93]:4844 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756180AbcHBLpr (ORCPT ); Tue, 2 Aug 2016 07:45:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1028257488" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, stefanr@s5r6.in-berlin.de, hal.rosenstock@gmail.com, bp@alien8.de Cc: linux-media@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, standby24x7@gmail.com Subject: [PATCH 0400/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:08:06 +0800 Message-Id: <20160802110806.8459-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/firewire/firedtv-avc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/firewire/firedtv-avc.c b/drivers/media/firewire/firedtv-avc.c index 251a556..e0fbc75 100644 --- a/drivers/media/firewire/firedtv-avc.c +++ b/drivers/media/firewire/firedtv-avc.c @@ -117,7 +117,7 @@ static void pad_operands(struct avc_command_frame *c, int from) #define AVC_DEBUG_FCP_PAYLOADS 0x8000 static int avc_debug; -module_param_named(debug, avc_debug, int, 0644); +module_param_named(debug, avc_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(debug, "Verbose logging (none = 0" ", FCP subactions" ": READ DESCRIPTOR = " __stringify(AVC_DEBUG_READ_DESCRIPTOR) @@ -140,7 +140,7 @@ MODULE_PARM_DESC(debug, "Verbose logging (none = 0" */ static unsigned int num_fake_ca_system_ids; static int fake_ca_system_ids[4] = { -1, -1, -1, -1 }; -module_param_array(fake_ca_system_ids, int, &num_fake_ca_system_ids, 0644); +module_param_array(fake_ca_system_ids, int, &num_fake_ca_system_ids, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(fake_ca_system_ids, "If your CAM application manufacturer " "does not have the same ca_system_id as your CAS, you can " "override what ca_system_ids are presented to the " -- 2.9.2