From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932996AbcHBROf (ORCPT ); Tue, 2 Aug 2016 13:14:35 -0400 Received: from mga09.intel.com ([134.134.136.24]:48335 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932576AbcHBLrp (ORCPT ); Tue, 2 Aug 2016 07:47:45 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1006938958" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, kyungmin.park@samsung.com, a.hajda@samsung.com, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, akpm@linux-foundation.org, g.liakhovetski@gmx.de Subject: [PATCH 0418/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:09:48 +0800 Message-Id: <20160802110948.9679-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/i2c/s5c73m3/s5c73m3-core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c/s5c73m3/s5c73m3-core.c index 08af58f..ec9cf9aa 100644 --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c @@ -40,13 +40,13 @@ #include "s5c73m3.h" int s5c73m3_dbg; -module_param_named(debug, s5c73m3_dbg, int, 0644); +module_param_named(debug, s5c73m3_dbg, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); static int boot_from_rom = 1; -module_param(boot_from_rom, int, 0644); +module_param(boot_from_rom, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); static int update_fw; -module_param(update_fw, int, 0644); +module_param(update_fw, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); #define S5C73M3_EMBEDDED_DATA_MAXLEN SZ_4K #define S5C73M3_MIPI_DATA_LANES 4 -- 2.9.2