From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756891AbcHBRMC (ORCPT ); Tue, 2 Aug 2016 13:12:02 -0400 Received: from mga09.intel.com ([134.134.136.24]:11237 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756564AbcHBLs5 (ORCPT ); Tue, 2 Aug 2016 07:48:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1018199543" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, hverkuil@xs4all.nl, a.hajda@samsung.com, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, k.kozlowski@samsung.com, arnd@arndb.de, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0433/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:11:16 +0800 Message-Id: <20160802111116.10690-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/i2c/tvaudio.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/media/i2c/tvaudio.c b/drivers/media/i2c/tvaudio.c index fece2a4..8c740d8 100644 --- a/drivers/media/i2c/tvaudio.c +++ b/drivers/media/i2c/tvaudio.c @@ -46,7 +46,7 @@ /* insmod args */ static int debug; /* insmod parameter */ -module_param(debug, int, 0644); +module_param(debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_DESCRIPTION("device driver for various i2c TV sound decoder / audiomux chips"); MODULE_AUTHOR("Eric Sandeen, Steve VanDeBogart, Greg Alexander, Gerd Knorr"); @@ -845,9 +845,9 @@ static int tda9874a_dic = -1; /* device id. code */ static unsigned int tda9874a_SIF = UNSET; static unsigned int tda9874a_AMSEL = UNSET; static unsigned int tda9874a_STD = UNSET; -module_param(tda9874a_SIF, int, 0444); -module_param(tda9874a_AMSEL, int, 0444); -module_param(tda9874a_STD, int, 0444); +module_param(tda9874a_SIF, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(tda9874a_AMSEL, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(tda9874a_STD, int, S_IRUSR | S_IRGRP | S_IROTH); /* * initialization table for tda9874 decoder: @@ -1454,18 +1454,18 @@ static int tea6420 = 1; static int pic16c54 = 1; static int ta8874z; /* default 0 - address clash with tda9840 */ -module_param(tda8425, int, 0444); -module_param(tda9840, int, 0444); -module_param(tda9850, int, 0444); -module_param(tda9855, int, 0444); -module_param(tda9873, int, 0444); -module_param(tda9874a, int, 0444); -module_param(tda9875, int, 0444); -module_param(tea6300, int, 0444); -module_param(tea6320, int, 0444); -module_param(tea6420, int, 0444); -module_param(pic16c54, int, 0444); -module_param(ta8874z, int, 0444); +module_param(tda8425, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(tda9840, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(tda9850, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(tda9855, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(tda9873, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(tda9874a, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(tda9875, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(tea6300, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(tea6320, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(tea6420, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(pic16c54, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(ta8874z, int, S_IRUSR | S_IRGRP | S_IROTH); static struct CHIPDESC chiplist[] = { { -- 2.9.2