From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933000AbcHBLyS (ORCPT ); Tue, 2 Aug 2016 07:54:18 -0400 Received: from mga01.intel.com ([192.55.52.88]:47479 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932871AbcHBLxL (ORCPT ); Tue, 2 Aug 2016 07:53:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1033577579" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, hverkuil@xs4all.nl, a.hajda@samsung.com, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, tiwai@suse.de, Julia.Lawall@lip6.fr, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0443/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:12:24 +0800 Message-Id: <20160802111224.11403-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/pci/bt8xx/bttv-cards.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/media/pci/bt8xx/bttv-cards.c b/drivers/media/pci/bt8xx/bttv-cards.c index 8a17cc0..a84caf4 100644 --- a/drivers/media/pci/bt8xx/bttv-cards.c +++ b/drivers/media/pci/bt8xx/bttv-cards.c @@ -109,21 +109,21 @@ static unsigned int audioall = UNSET; static unsigned int audiomux[5] = { [ 0 ... 4 ] = UNSET }; /* insmod options */ -module_param(triton1, int, 0444); -module_param(vsfx, int, 0444); -module_param(no_overlay, int, 0444); -module_param(latency, int, 0444); -module_param(gpiomask, int, 0444); -module_param(audioall, int, 0444); -module_param(autoload, int, 0444); - -module_param_array(card, int, NULL, 0444); -module_param_array(pll, int, NULL, 0444); -module_param_array(tuner, int, NULL, 0444); -module_param_array(svhs, int, NULL, 0444); -module_param_array(remote, int, NULL, 0444); -module_param_array(audiodev, int, NULL, 0444); -module_param_array(audiomux, int, NULL, 0444); +module_param(triton1, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(vsfx, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(no_overlay, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(latency, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(gpiomask, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(audioall, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(autoload, int, S_IRUSR | S_IRGRP | S_IROTH); + +module_param_array(card, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); +module_param_array(pll, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); +module_param_array(tuner, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); +module_param_array(svhs, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); +module_param_array(remote, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); +module_param_array(audiodev, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); +module_param_array(audiomux, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(triton1,"set ETBF pci config bit " "[enable bug compatibility for triton1 + others]"); -- 2.9.2