From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967777AbcHBQKN (ORCPT ); Tue, 2 Aug 2016 12:10:13 -0400 Received: from mga11.intel.com ([192.55.52.93]:54096 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934317AbcHBMRu (ORCPT ); Tue, 2 Aug 2016 08:17:50 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="743074613" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, hverkuil@xs4all.nl, a.hajda@samsung.com, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, geliangtang@163.com, hdegoede@redhat.com, elfring@users.sourceforge.net Subject: [PATCH 0445/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:12:38 +0800 Message-Id: <20160802111238.11539-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/pci/bt8xx/bttv-i2c.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/pci/bt8xx/bttv-i2c.c b/drivers/media/pci/bt8xx/bttv-i2c.c index d43911d..ab65dec 100644 --- a/drivers/media/pci/bt8xx/bttv-i2c.c +++ b/drivers/media/pci/bt8xx/bttv-i2c.c @@ -41,16 +41,16 @@ static int i2c_debug; static int i2c_hw; static int i2c_scan; -module_param(i2c_debug, int, 0644); +module_param(i2c_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(i2c_debug, "configure i2c debug level"); -module_param(i2c_hw, int, 0444); +module_param(i2c_hw, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(i2c_hw,"force use of hardware i2c support, " "instead of software bitbang"); -module_param(i2c_scan, int, 0444); +module_param(i2c_scan, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(i2c_scan,"scan i2c bus at insmod time"); static unsigned int i2c_udelay = 5; -module_param(i2c_udelay, int, 0444); +module_param(i2c_udelay, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(i2c_udelay,"soft i2c delay at insmod time, in usecs " "(should be 5 or higher). Lower value means higher bus speed."); -- 2.9.2