From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935155AbcHBQNG (ORCPT ); Tue, 2 Aug 2016 12:13:06 -0400 Received: from mga03.intel.com ([134.134.136.65]:25848 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933866AbcHBMRi (ORCPT ); Tue, 2 Aug 2016 08:17:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1033577873" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, hverkuil@xs4all.nl, a.hajda@samsung.com, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, hans.verkuil@cisco.com, klock.android@gmail.com, chuansheng.liu@intel.com, baolex.ni@intel.com, elfring@users.sourceforge.net Subject: [PATCH 0446/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:12:45 +0800 Message-Id: <20160802111245.11609-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/pci/bt8xx/bttv-input.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/bt8xx/bttv-input.c b/drivers/media/pci/bt8xx/bttv-input.c index a75c53d..b422894 100644 --- a/drivers/media/pci/bt8xx/bttv-input.c +++ b/drivers/media/pci/bt8xx/bttv-input.c @@ -32,10 +32,10 @@ static int ir_debug; -module_param(ir_debug, int, 0644); +module_param(ir_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); static int ir_rc5_remote_gap = 885; -module_param(ir_rc5_remote_gap, int, 0644); +module_param(ir_rc5_remote_gap, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); #undef dprintk #define dprintk(fmt, ...) \ -- 2.9.2