From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967860AbcHBQMz (ORCPT ); Tue, 2 Aug 2016 12:12:55 -0400 Received: from mga09.intel.com ([134.134.136.24]:62662 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934276AbcHBMRj (ORCPT ); Tue, 2 Aug 2016 08:17:39 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="858107128" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, hverkuil@xs4all.nl, a.hajda@samsung.com, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, elfring@users.sourceforge.net Subject: [PATCH 0447/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:12:52 +0800 Message-Id: <20160802111252.11677-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/pci/bt8xx/bttv-vbi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/bt8xx/bttv-vbi.c b/drivers/media/pci/bt8xx/bttv-vbi.c index e77129c..af2ce4a 100644 --- a/drivers/media/pci/bt8xx/bttv-vbi.c +++ b/drivers/media/pci/bt8xx/bttv-vbi.c @@ -59,8 +59,8 @@ static unsigned int vbibufs = 4; static unsigned int vbi_debug; -module_param(vbibufs, int, 0444); -module_param(vbi_debug, int, 0644); +module_param(vbibufs, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(vbi_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(vbibufs,"number of vbi buffers, range 2-32, default 4"); MODULE_PARM_DESC(vbi_debug,"vbi code debug messages, default is 0 (no)"); -- 2.9.2