From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932973AbcHBL6q (ORCPT ); Tue, 2 Aug 2016 07:58:46 -0400 Received: from mga11.intel.com ([192.55.52.93]:27146 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932834AbcHBLwp (ORCPT ); Tue, 2 Aug 2016 07:52:45 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="743074778" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, hans.verkuil@cisco.com, a.hajda@samsung.com, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, elfring@users.sourceforge.net Subject: [PATCH 0452/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:13:20 +0800 Message-Id: <20160802111320.12013-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/pci/cobalt/cobalt-driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/cobalt/cobalt-driver.c b/drivers/media/pci/cobalt/cobalt-driver.c index 8d6f04f..4a6acae 100644 --- a/drivers/media/pci/cobalt/cobalt-driver.c +++ b/drivers/media/pci/cobalt/cobalt-driver.c @@ -47,11 +47,11 @@ MODULE_DEVICE_TABLE(pci, cobalt_pci_tbl); static atomic_t cobalt_instance = ATOMIC_INIT(0); int cobalt_debug; -module_param_named(debug, cobalt_debug, int, 0644); +module_param_named(debug, cobalt_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(debug, "Debug level. Default: 0\n"); int cobalt_ignore_err; -module_param_named(ignore_err, cobalt_ignore_err, int, 0644); +module_param_named(ignore_err, cobalt_ignore_err, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(ignore_err, "If set then ignore missing i2c adapters/receivers. Default: 0\n"); -- 2.9.2