From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932917AbcHBL63 (ORCPT ); Tue, 2 Aug 2016 07:58:29 -0400 Received: from mga09.intel.com ([134.134.136.24]:32008 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932831AbcHBLwp (ORCPT ); Tue, 2 Aug 2016 07:52:45 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1018200811" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, awalls@md.metrocast.net, a.hajda@samsung.com, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, dheitmueller@kernellabs.com, hans.verkuil@cisco.com, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0460/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:14:06 +0800 Message-Id: <20160802111406.12553-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/pci/cx23885/cx23885-cards.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/cx23885/cx23885-cards.c b/drivers/media/pci/cx23885/cx23885-cards.c index 310ee76..c6d28d7 100644 --- a/drivers/media/pci/cx23885/cx23885-cards.c +++ b/drivers/media/pci/cx23885/cx23885-cards.c @@ -33,11 +33,11 @@ #include "cx23888-ir.h" static unsigned int netup_card_rev = 4; -module_param(netup_card_rev, int, 0644); +module_param(netup_card_rev, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(netup_card_rev, "NetUP Dual DVB-T/C CI card revision"); static unsigned int enable_885_ir; -module_param(enable_885_ir, int, 0644); +module_param(enable_885_ir, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(enable_885_ir, "Enable integrated IR controller for supported\n" "\t\t CX2388[57] boards that are wired for it:\n" -- 2.9.2