From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756697AbcHBL4g (ORCPT ); Tue, 2 Aug 2016 07:56:36 -0400 Received: from mga02.intel.com ([134.134.136.20]:23100 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932850AbcHBLwy (ORCPT ); Tue, 2 Aug 2016 07:52:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1028260632" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, awalls@md.metrocast.net, a.hajda@samsung.com, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, hans.verkuil@cisco.com, sw0312.kim@samsung.com, jh1009.sung@samsung.com, nenggun.kim@samsung.com, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0470/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:15:12 +0800 Message-Id: <20160802111512.13234-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/pci/cx25821/cx25821-video.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/pci/cx25821/cx25821-video.c b/drivers/media/pci/cx25821/cx25821-video.c index c48bba9..7a8ee16 100644 --- a/drivers/media/pci/cx25821/cx25821-video.c +++ b/drivers/media/pci/cx25821/cx25821-video.c @@ -34,16 +34,16 @@ MODULE_LICENSE("GPL"); static unsigned int video_nr[] = {[0 ... (CX25821_MAXBOARDS - 1)] = UNSET }; -module_param_array(video_nr, int, NULL, 0444); +module_param_array(video_nr, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(video_nr, "video device numbers"); static unsigned int video_debug = VIDEO_DEBUG; -module_param(video_debug, int, 0644); +module_param(video_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(video_debug, "enable debug messages [video]"); static unsigned int irq_debug; -module_param(irq_debug, int, 0644); +module_param(irq_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(irq_debug, "enable debug messages [IRQ handler]"); #define FORMAT_FLAGS_PACKED 0x01 -- 2.9.2