From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756680AbcHBLz5 (ORCPT ); Tue, 2 Aug 2016 07:55:57 -0400 Received: from mga02.intel.com ([134.134.136.20]:13042 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932789AbcHBLxZ (ORCPT ); Tue, 2 Aug 2016 07:53:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1018201428" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, awalls@md.metrocast.net, a.hajda@samsung.com, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, sw0312.kim@samsung.com, jh1009.sung@samsung.com, nenggun.kim@samsung.com, inki.dae@samsung.com, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0474/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:15:38 +0800 Message-Id: <20160802111538.13508-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/pci/cx88/cx88-core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/pci/cx88/cx88-core.c b/drivers/media/pci/cx88/cx88-core.c index 46fe8c1..6125b9e 100644 --- a/drivers/media/pci/cx88/cx88-core.c +++ b/drivers/media/pci/cx88/cx88-core.c @@ -49,15 +49,15 @@ MODULE_LICENSE("GPL"); /* ------------------------------------------------------------------ */ unsigned int cx88_core_debug; -module_param_named(core_debug, cx88_core_debug, int, 0644); +module_param_named(core_debug, cx88_core_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(core_debug, "enable debug messages [core]"); static unsigned int nicam; -module_param(nicam,int,0644); +module_param(nicam,int,S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(nicam,"tv audio is nicam"); static unsigned int nocomb; -module_param(nocomb,int,0644); +module_param(nocomb,int,S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(nocomb,"disable comb filter"); #define dprintk(level,fmt, arg...) do { \ -- 2.9.2