From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030409AbcHBRCy (ORCPT ); Tue, 2 Aug 2016 13:02:54 -0400 Received: from mga11.intel.com ([192.55.52.93]:4033 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932860AbcHBMAA (ORCPT ); Tue, 2 Aug 2016 08:00:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1018201560" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, awalls@md.metrocast.net, a.hajda@samsung.com, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, jh1009.sung@samsung.com, nenggun.kim@samsung.com Subject: [PATCH 0478/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:16:04 +0800 Message-Id: <20160802111604.13787-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/pci/cx88/cx88-input.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/cx88/cx88-input.c b/drivers/media/pci/cx88/cx88-input.c index 3f1342c..e813667 100644 --- a/drivers/media/pci/cx88/cx88-input.c +++ b/drivers/media/pci/cx88/cx88-input.c @@ -58,11 +58,11 @@ struct cx88_IR { }; static unsigned ir_samplerate = 4; -module_param(ir_samplerate, uint, 0444); +module_param(ir_samplerate, uint, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(ir_samplerate, "IR samplerate in kHz, 1 - 20, default 4"); static int ir_debug; -module_param(ir_debug, int, 0644); /* debug level [IR] */ +module_param(ir_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); /* debug level [IR] */ MODULE_PARM_DESC(ir_debug, "enable debug messages [IR]"); #define ir_dprintk(fmt, arg...) if (ir_debug) \ -- 2.9.2