From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935627AbcHBQ4a (ORCPT ); Tue, 2 Aug 2016 12:56:30 -0400 Received: from mga01.intel.com ([192.55.52.88]:29241 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932729AbcHBMAE (ORCPT ); Tue, 2 Aug 2016 08:00:04 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="149302275" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, awalls@md.metrocast.net, a.hajda@samsung.com, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, lars@metafoo.de, chuansheng.liu@intel.com, baolex.ni@intel.com, sw0312.kim@samsung.com, jh1009.sung@samsung.com Subject: [PATCH 0483/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:16:38 +0800 Message-Id: <20160802111638.14133-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/pci/dm1105/dm1105.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/dm1105/dm1105.c b/drivers/media/pci/dm1105/dm1105.c index 5dd5047..2983f35 100644 --- a/drivers/media/pci/dm1105/dm1105.c +++ b/drivers/media/pci/dm1105/dm1105.c @@ -195,11 +195,11 @@ #define UNBR_LNB_18V (GPIO17 | GPIO16) static unsigned int card[] = {[0 ... 3] = UNSET }; -module_param_array(card, int, NULL, 0444); +module_param_array(card, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(card, "card type"); static int ir_debug; -module_param(ir_debug, int, 0644); +module_param(ir_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(ir_debug, "enable debugging information for IR decoding"); static unsigned int dm1105_devcount; -- 2.9.2