From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935556AbcHBQrd (ORCPT ); Tue, 2 Aug 2016 12:47:33 -0400 Received: from mga09.intel.com ([134.134.136.24]:7892 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933225AbcHBMAk (ORCPT ); Tue, 2 Aug 2016 08:00:40 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="743075638" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, awalls@md.metrocast.net, a.hajda@samsung.com, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, sw0312.kim@samsung.com, jh1009.sung@samsung.com Subject: [PATCH 0487/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:16:57 +0800 Message-Id: <20160802111657.14397-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/pci/ivtv/ivtvfb.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/media/pci/ivtv/ivtvfb.c b/drivers/media/pci/ivtv/ivtvfb.c index 8b95eef..5ca03ff 100644 --- a/drivers/media/pci/ivtv/ivtvfb.c +++ b/drivers/media/pci/ivtv/ivtvfb.c @@ -67,14 +67,14 @@ static int osd_left; static int osd_yres; static int osd_xres; -module_param(ivtvfb_card_id, int, 0444); -module_param_named(debug,ivtvfb_debug, int, 0644); -module_param(osd_laced, bool, 0444); -module_param(osd_depth, int, 0444); -module_param(osd_upper, int, 0444); -module_param(osd_left, int, 0444); -module_param(osd_yres, int, 0444); -module_param(osd_xres, int, 0444); +module_param(ivtvfb_card_id, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param_named(debug,ivtvfb_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param(osd_laced, bool, S_IRUSR | S_IRGRP | S_IROTH); +module_param(osd_depth, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(osd_upper, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(osd_left, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(osd_yres, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(osd_xres, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(ivtvfb_card_id, "Only use framebuffer of the specified ivtv card (0-31)\n" -- 2.9.2