From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030367AbcHBRCT (ORCPT ); Tue, 2 Aug 2016 13:02:19 -0400 Received: from mga04.intel.com ([192.55.52.120]:54609 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933040AbcHBMAA (ORCPT ); Tue, 2 Aug 2016 08:00:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="858109754" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, awalls@md.metrocast.net, a.hajda@samsung.com, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, sw0312.kim@samsung.com, jh1009.sung@samsung.com Subject: [PATCH 0490/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:17:16 +0800 Message-Id: <20160802111716.14604-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/pci/meye/meye.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/pci/meye/meye.c b/drivers/media/pci/meye/meye.c index ba887e8..8283113 100644 --- a/drivers/media/pci/meye/meye.c +++ b/drivers/media/pci/meye/meye.c @@ -54,18 +54,18 @@ MODULE_VERSION(MEYE_DRIVER_VERSION); /* number of grab buffers */ static unsigned int gbuffers = 2; -module_param(gbuffers, int, 0444); +module_param(gbuffers, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(gbuffers, "number of capture buffers, default is 2 (32 max)"); /* size of a grab buffer */ static unsigned int gbufsize = MEYE_MAX_BUFSIZE; -module_param(gbufsize, int, 0444); +module_param(gbufsize, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(gbufsize, "size of the capture buffers, default is 614400" " (will be rounded up to a page multiple)"); /* /dev/videoX registration number */ static int video_nr = -1; -module_param(video_nr, int, 0444); +module_param(video_nr, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(video_nr, "video device to register (0=/dev/video0, etc)"); /* driver structure - only one possible */ -- 2.9.2