From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935655AbcHBQ4o (ORCPT ); Tue, 2 Aug 2016 12:56:44 -0400 Received: from mga04.intel.com ([192.55.52.120]:14216 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933056AbcHBMAE (ORCPT ); Tue, 2 Aug 2016 08:00:04 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="743075810" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, awalls@md.metrocast.net, a.hajda@samsung.com, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, sw0312.kim@samsung.com, jh1009.sung@samsung.com Subject: [PATCH 0492/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:17:29 +0800 Message-Id: <20160802111729.14740-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/pci/pt3/pt3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/pt3/pt3.c b/drivers/media/pci/pt3/pt3.c index eff5e9f..feddb59 100644 --- a/drivers/media/pci/pt3/pt3.c +++ b/drivers/media/pci/pt3/pt3.c @@ -32,11 +32,11 @@ DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr); static bool one_adapter; -module_param(one_adapter, bool, 0444); +module_param(one_adapter, bool, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(one_adapter, "Place FE's together under one adapter."); static int num_bufs = 4; -module_param(num_bufs, int, 0444); +module_param(num_bufs, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(num_bufs, "Number of DMA buffer (188KiB) per FE."); -- 2.9.2