From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935521AbcHBRAJ (ORCPT ); Tue, 2 Aug 2016 13:00:09 -0400 Received: from mga02.intel.com ([134.134.136.20]:58824 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933048AbcHBMAB (ORCPT ); Tue, 2 Aug 2016 08:00:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1028261621" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, awalls@md.metrocast.net, a.hajda@samsung.com, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, sw0312.kim@samsung.com, jh1009.sung@samsung.com, nenggun.kim@samsung.com, arnd@arndb.de, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0494/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:17:41 +0800 Message-Id: <20160802111741.14876-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/pci/saa7134/saa7134-core.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/media/pci/saa7134/saa7134-core.c b/drivers/media/pci/saa7134/saa7134-core.c index c0e1780..6349a3f 100644 --- a/drivers/media/pci/saa7134/saa7134-core.c +++ b/drivers/media/pci/saa7134/saa7134-core.c @@ -45,32 +45,32 @@ MODULE_VERSION(SAA7134_VERSION); /* ------------------------------------------------------------------ */ static unsigned int irq_debug; -module_param(irq_debug, int, 0644); +module_param(irq_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(irq_debug,"enable debug messages [IRQ handler]"); static unsigned int core_debug; -module_param(core_debug, int, 0644); +module_param(core_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(core_debug,"enable debug messages [core]"); static unsigned int gpio_tracking; -module_param(gpio_tracking, int, 0644); +module_param(gpio_tracking, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(gpio_tracking,"enable debug messages [gpio]"); static unsigned int alsa = 1; -module_param(alsa, int, 0644); +module_param(alsa, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(alsa,"enable/disable ALSA DMA sound [dmasound]"); static unsigned int latency = UNSET; -module_param(latency, int, 0444); +module_param(latency, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(latency,"pci latency timer"); int saa7134_no_overlay=-1; -module_param_named(no_overlay, saa7134_no_overlay, int, 0444); +module_param_named(no_overlay, saa7134_no_overlay, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(no_overlay,"allow override overlay default (0 disables, 1 enables)" " [some VIA/SIS chipsets are known to have problem with overlay]"); bool saa7134_userptr; -module_param(saa7134_userptr, bool, 0644); +module_param(saa7134_userptr, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(saa7134_userptr, "enable page-aligned userptr support"); static unsigned int video_nr[] = {[0 ... (SAA7134_MAXBOARDS - 1)] = UNSET }; @@ -80,11 +80,11 @@ static unsigned int tuner[] = {[0 ... (SAA7134_MAXBOARDS - 1)] = UNSET }; static unsigned int card[] = {[0 ... (SAA7134_MAXBOARDS - 1)] = UNSET }; -module_param_array(video_nr, int, NULL, 0444); -module_param_array(vbi_nr, int, NULL, 0444); -module_param_array(radio_nr, int, NULL, 0444); -module_param_array(tuner, int, NULL, 0444); -module_param_array(card, int, NULL, 0444); +module_param_array(video_nr, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); +module_param_array(vbi_nr, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); +module_param_array(radio_nr, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); +module_param_array(tuner, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); +module_param_array(card, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(video_nr, "video device number"); MODULE_PARM_DESC(vbi_nr, "vbi device number"); -- 2.9.2