From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933054AbcHBMAD (ORCPT ); Tue, 2 Aug 2016 08:00:03 -0400 Received: from mga11.intel.com ([192.55.52.93]:30351 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756719AbcHBL6Y (ORCPT ); Tue, 2 Aug 2016 07:58:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="149302774" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, awalls@md.metrocast.net, a.hajda@samsung.com, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, hans.verkuil@cisco.com, sw0312.kim@samsung.com, jh1009.sung@samsung.com, nenggun.kim@samsung.com, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0499/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:18:14 +0800 Message-Id: <20160802111814.15216-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/pci/saa7134/saa7134-ts.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/pci/saa7134/saa7134-ts.c b/drivers/media/pci/saa7134/saa7134-ts.c index 0584a2a..36db56d 100644 --- a/drivers/media/pci/saa7134/saa7134-ts.c +++ b/drivers/media/pci/saa7134/saa7134-ts.c @@ -32,7 +32,7 @@ /* ------------------------------------------------------------------ */ static unsigned int ts_debug; -module_param(ts_debug, int, 0644); +module_param(ts_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(ts_debug,"enable debug messages [ts]"); #define ts_dbg(fmt, arg...) do { \ @@ -190,11 +190,11 @@ EXPORT_SYMBOL_GPL(saa7134_ts_qops); /* exported stuff */ static unsigned int tsbufs = 8; -module_param(tsbufs, int, 0444); +module_param(tsbufs, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(tsbufs, "number of ts buffers for read/write IO, range 2-32"); static unsigned int ts_nr_packets = 64; -module_param(ts_nr_packets, int, 0444); +module_param(ts_nr_packets, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(ts_nr_packets,"size of a ts buffers (in ts packets)"); int saa7134_ts_init_hw(struct saa7134_dev *dev) -- 2.9.2