From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933023AbcHBL7v (ORCPT ); Tue, 2 Aug 2016 07:59:51 -0400 Received: from mga03.intel.com ([134.134.136.65]:47475 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756721AbcHBL6Y (ORCPT ); Tue, 2 Aug 2016 07:58:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1018202557" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, awalls@md.metrocast.net, a.hajda@samsung.com, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, hans.verkuil@cisco.com, sw0312.kim@samsung.com, jh1009.sung@samsung.com, nenggun.kim@samsung.com, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0501/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:18:29 +0800 Message-Id: <20160802111829.15352-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/pci/saa7134/saa7134-vbi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/saa7134/saa7134-vbi.c b/drivers/media/pci/saa7134/saa7134-vbi.c index e76da37..4baf762 100644 --- a/drivers/media/pci/saa7134/saa7134-vbi.c +++ b/drivers/media/pci/saa7134/saa7134-vbi.c @@ -31,11 +31,11 @@ /* ------------------------------------------------------------------ */ static unsigned int vbi_debug; -module_param(vbi_debug, int, 0644); +module_param(vbi_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(vbi_debug,"enable debug messages [vbi]"); static unsigned int vbibufs = 4; -module_param(vbibufs, int, 0444); +module_param(vbibufs, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(vbibufs,"number of vbi buffers, range 2-32"); #define vbi_dbg(fmt, arg...) do { \ -- 2.9.2