From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933166AbcHBMAc (ORCPT ); Tue, 2 Aug 2016 08:00:32 -0400 Received: from mga02.intel.com ([134.134.136.20]:51955 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933076AbcHBMAM (ORCPT ); Tue, 2 Aug 2016 08:00:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="743076228" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, maintainers@bluecherrydvr.com, andrey.utkin@corp.bluecherry.net, ismael@iodev.co.uk, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, jh1009.sung@samsung.com, nenggun.kim@samsung.com, hdegoede@redhat.com Subject: [PATCH 0506/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:18:59 +0800 Message-Id: <20160802111859.15687-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/pci/solo6x10/solo6x10-p2m.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/solo6x10/solo6x10-p2m.c b/drivers/media/pci/solo6x10/solo6x10-p2m.c index 8c84846..11f0ec0 100644 --- a/drivers/media/pci/solo6x10/solo6x10-p2m.c +++ b/drivers/media/pci/solo6x10/solo6x10-p2m.c @@ -25,12 +25,12 @@ #include "solo6x10.h" static int multi_p2m; -module_param(multi_p2m, uint, 0644); +module_param(multi_p2m, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(multi_p2m, "Use multiple P2M DMA channels (default: no, 6010-only)"); static int desc_mode; -module_param(desc_mode, uint, 0644); +module_param(desc_mode, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(desc_mode, "Allow use of descriptor mode DMA (default: no, 6010-only)"); -- 2.9.2