From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934381AbcHBQ7v (ORCPT ); Tue, 2 Aug 2016 12:59:51 -0400 Received: from mga09.intel.com ([134.134.136.24]:43060 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932863AbcHBMAB (ORCPT ); Tue, 2 Aug 2016 08:00:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="743076380" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, maintainers@bluecherrydvr.com, andrey.utkin@corp.bluecherry.net, ismael@iodev.co.uk, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, hverkuil@xs4all.nl, akpm@linux-foundation.org, ezequiel@vanguardiasur.com.ar, chuansheng.liu@intel.com, baolex.ni@intel.com, hdegoede@redhat.com Subject: [PATCH 0512/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:19:38 +0800 Message-Id: <20160802111938.16095-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/pci/tw68/tw68-core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/pci/tw68/tw68-core.c b/drivers/media/pci/tw68/tw68-core.c index 4e77618..3f6af07 100644 --- a/drivers/media/pci/tw68/tw68-core.c +++ b/drivers/media/pci/tw68/tw68-core.c @@ -50,15 +50,15 @@ MODULE_AUTHOR("Hans Verkuil "); MODULE_LICENSE("GPL"); static unsigned int latency = UNSET; -module_param(latency, int, 0444); +module_param(latency, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(latency, "pci latency timer"); static unsigned int video_nr[] = {[0 ... (TW68_MAXBOARDS - 1)] = UNSET }; -module_param_array(video_nr, int, NULL, 0444); +module_param_array(video_nr, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(video_nr, "video device number"); static unsigned int card[] = {[0 ... (TW68_MAXBOARDS - 1)] = UNSET }; -module_param_array(card, int, NULL, 0444); +module_param_array(card, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(card, "card type"); static atomic_t tw68_instance = ATOMIC_INIT(0); -- 2.9.2