From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030279AbcHBQ5Y (ORCPT ); Tue, 2 Aug 2016 12:57:24 -0400 Received: from mga09.intel.com ([134.134.136.24]:40931 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933039AbcHBMAB (ORCPT ); Tue, 2 Aug 2016 08:00:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1033580337" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, ezequiel@vanguardiasur.com.ar, andrey.utkin@corp.bluecherry.net, ismael@iodev.co.uk, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, hdegoede@redhat.com Subject: [PATCH 0513/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:19:43 +0800 Message-Id: <20160802111943.16162-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/pci/tw686x/tw686x-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/tw686x/tw686x-core.c b/drivers/media/pci/tw686x/tw686x-core.c index cf53b0e..5b6b291 100644 --- a/drivers/media/pci/tw686x/tw686x-core.c +++ b/drivers/media/pci/tw686x/tw686x-core.c @@ -52,7 +52,7 @@ * determine the desired value through testing. */ static u32 dma_interval = 0x00098968; -module_param(dma_interval, int, 0444); +module_param(dma_interval, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(dma_interval, "Minimum time span for DMA interrupting host"); void tw686x_disable_channel(struct tw686x_dev *dev, unsigned int channel) -- 2.9.2